Skip to content

[FEAT] - revamp UI card testimonial #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2025

Conversation

mpsalunggg
Copy link
Member

Description

  • Revamp ui card testimonial

Screenshots (if applicable)

image

@mpsalunggg mpsalunggg self-assigned this May 23, 2025
@mpsalunggg mpsalunggg added the enhancement New feature or request label May 23, 2025
Copy link
Member

@morizkay morizkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like can transforming the cursor with the y axis will be better, can change:

             whileHover={{ y: -5 }}

To

              whileHover={{
                y: -5,
                cursor: "pointer",
              }}

So the cursor transforms to pointer when hovering on the card, I think it's an addition to declare This can be click with the moving y axis.

And is there any reason why the dialog pop up only triggered when click/tap on the testimonial text? Not the whole card? Seems like since the card is transform on hover, then it should be the one who can be trigger the dialog, not only the text.

Can see the video for reference
https://ss.rizky.id/8QBFPK3TYBmfd7NQXkFZ

@mpsalunggg mpsalunggg merged commit 8e8d60d into development May 24, 2025
@mpsalunggg
Copy link
Member Author

@morizkay the comment will be fix later, @adzaky adlim will fix it xixixi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants