-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove unnecessary duplicate types from Types.ts
#622
Conversation
Hey @georgefst, this pull request failed to merge and has been dequeued from the merge train. If you believe your PR failed in the merge train because of a flaky test, requeue it by commenting with |
I suspect this conflicts with #611, given that it is complaining about
|
Yep, I'll rebase. |
I think I messed up that pr and used the Sorry for the extra work! |
No worries, I can't blame you - the state of things before this change was quite confusing. |
9420090
to
b01bcfd
Compare
In fact, some of these types no longer even exist in the backend / primer-api.
b01bcfd
to
ae1e77f
Compare
Deploying with
|
Latest commit: |
ae1e77f
|
Status: | ✅ Deploy successful! |
Preview URL: | https://677457fe.primer-app.pages.dev |
Branch Preview URL: | https://georgefst-no-duplicate-types.primer-app.pages.dev |
If I'd reviewed #547 more thoroughly, I might've noticed that we no longer needed these duplicate types, which previously existed to work around our awkward dependency graph.
But then, that PR did touch 151 files.