Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: fix condition to determin isOwner #47

Merged
merged 2 commits into from
Jan 10, 2025
Merged

daemon: fix condition to determin isOwner #47

merged 2 commits into from
Jan 10, 2025

Conversation

huikang
Copy link
Contributor

@huikang huikang commented Jan 9, 2025

Based on the definition of AdvertiseAddress and GRPCListenAddress, I think here we should use AdvertiseAddress, which is default to GRPCListenAddress. However, if node is behind a NAT, we need to set AdvertiseAddress to a different value than GRPCListenAddress.

@huikang huikang requested a review from Baliedge as a code owner January 9, 2025 04:16
thrawn01
thrawn01 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@thrawn01 thrawn01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised this mistake was not noticed until now. Thank you for the PR!

@thrawn01 thrawn01 merged commit fd5aaf7 into gubernator-io:master Jan 10, 2025
4 checks passed
@huikang huikang deleted the huikang/embedded-discovery-type branch January 10, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thrawn01 thrawn01 thrawn01 approved these changes

@Baliedge Baliedge Awaiting requested review from Baliedge Baliedge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@huikang @thrawn01