[Bug fix] tls reload: enable for client cert #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove unused fields in TLSConfig struct
huikang
force-pushed
the
hk/fix-tls-client-cert
branch
from
82762bf to
b7ea1f6
Compare
huikang
changed the title
huikang
changed the title
|
@thrawn01 , do you mind taking a look at this PR? |
huikang
commented
Jan 2, 2025
| @@ -109,12 +109,6 @@ type TLSConfig struct { | |||
| // (Optional) The client auth CA Certificate in PEM format. Used if ClientAuthCaFile is unset. | |||
| ClientAuthCaPEM *bytes.Buffer | |||
|
|
|||
| // (Optional) The client auth private key in PEM format. Used if ClientAuthKeyFile is unset. | |||
| ClientAuthKeyPEM *bytes.Buffer | |||
There was a problem hiding this comment.
The fields are not used throughout the code
thrawn01
approved these changes
Jan 2, 2025
|
@thrawn01 , thanks for merging. I guess we need a new minor release for the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in reloading the tls certificate for the gRPC client. Gubernator instance reports messages
remote error: tls: expired certificateafter running for a couple of days.What caused the problem
in the current implementation, the client certificate of the key reload refers to a slice of
tls.Certificatestruct. During reload, there could be a chance the certificate is not loaded correctly, leading to the tls expiration error.How the PR fixes the issue
We use the
tls.GetClientCertificatescallback function to load the certificate for gRPC client to avoid any race condition. Additional improvements are that hot-reload of client cert is supported as well in this PR.Test
We deployed an image with the fix in 3-node cluster and let it run for 5 days with tls
ttl=5m. There has been no error of tls expiration.