-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate uglify's new object property mangling capabilities #312
Conversation
Thanks for the PR! some tests are failing though :( |
I'm still waiting for a reply from @vladikoff 'cause as you can see from here https://github.com/gruntjs/grunt-contrib-uglify/compare/tests, I only managed to fix 2... |
+1 for the PR! |
@jrhite could you please rebase your PR? also no need to update the changelog |
Rebased PR and reverted changelog changes... Thanks! On Tue, Mar 31, 2015 at 3:33 AM, Vlad Filippov [email protected]
|
@@ -1,7 +1,7 @@ | |||
{ | |||
"name": "grunt-contrib-uglify", | |||
"description": "Minify files with UglifyJS.", | |||
"version": "0.8.1", | |||
"version": "0.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be reverted too.
+1 ! |
really good idea! +1 |
best idea ever +1 |
@XhmikosR I just reverted the package.json version change and rebased to the latest code. Should be good to go. Cheers! |
@@ -139,3 +139,31 @@ Type: `Boolean` | |||
Default: false | |||
|
|||
Pass this flag if you don't care about full compliance with Internet Explorer 6-8 quirks. | |||
|
|||
## mangleProperties | |||
Type: `Boolean` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs 2 tailing spaces for a new line for all the newly added types.
…perty name mangling functionality, the ability to pass files containing property and variable name exceptions and the ability to use a cache to coordinate symbol mangling across multiple calls to uglify. See uglifyjs v2.4.18 https://www.npmjs.com/package/uglify-js for more info.
@XhmikosR good eye again! (uggh...MD requires 2 extra spaces like that...still learning it :-) ) I went ahead and add the 2 trailing spaces to all the new options in docs/uglify-options.md. I also fixed some of the older options that were missing this too. Checked in and rebased. Thanks! |
Incorporate uglify's new object property mangling capabilities
Thanks! |
Thanks! @XhmikosR when/how will this make it to the npm repo? it will be version 0.8.2, correct? |
I don't make the releases myself so when @vladikoff thinks it's OK :P Though, perhaps we could wait a couple of days in case we merge some of the other PRs too. |
Ah, got it ok. Thanks... No big rush here, but the sooner the better of course! :-) On Thu, Apr 2, 2015 at 12:28 PM, XhmikosR [email protected] wrote:
|
Updated grunt wrapper to be able to hook into uglify's new object property name mangling functionality, the ability to pass files containing property and variable name exceptions and the ability to use a cache to coordinate symbol mangling across multiple calls to uglify.
See uglifyjs v2.4.19 https://www.npmjs.com/package/uglify-js for more info.