Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate uglify's new object property mangling capabilities #312

Merged
merged 1 commit into from
Apr 2, 2015
Merged

Incorporate uglify's new object property mangling capabilities #312

merged 1 commit into from
Apr 2, 2015

Conversation

jrhite
Copy link
Contributor

@jrhite jrhite commented Mar 29, 2015

Updated grunt wrapper to be able to hook into uglify's new object property name mangling functionality, the ability to pass files containing property and variable name exceptions and the ability to use a cache to coordinate symbol mangling across multiple calls to uglify.

See uglifyjs v2.4.19 https://www.npmjs.com/package/uglify-js for more info.

@vladikoff
Copy link
Member

Thanks for the PR! some tests are failing though :(

@jrhite
Copy link
Contributor Author

jrhite commented Mar 30, 2015

The 4 failing tests have been failing since commit: 8f9bb92. Earlier comments from @XhmikosR say that he is on it and fixing them.

I added 5 new tests specific to the new functionality and they're all passing.

@jrhite jrhite changed the title Updated grunt wrapper to be ablel to hook into uglify's new object prope... Incorporate uglify's new object property mangling capabilities Mar 30, 2015
@XhmikosR
Copy link
Member

I'm still waiting for a reply from @vladikoff 'cause as you can see from here https://github.com/gruntjs/grunt-contrib-uglify/compare/tests, I only managed to fix 2...

@pdachtera
Copy link

+1 for the PR!

@vladikoff
Copy link
Member

@jrhite could you please rebase your PR? also no need to update the changelog

@jrhite
Copy link
Contributor Author

jrhite commented Mar 31, 2015

Rebased PR and reverted changelog changes...

Thanks!

On Tue, Mar 31, 2015 at 3:33 AM, Vlad Filippov [email protected]
wrote:

@jrhite https://github.com/jrhite could you please rebase your PR? also
no need to update the changelog


Reply to this email directly or view it on GitHub
#312 (comment)
.

@@ -1,7 +1,7 @@
{
"name": "grunt-contrib-uglify",
"description": "Minify files with UglifyJS.",
"version": "0.8.1",
"version": "0.9.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted too.

@chesserik
Copy link

+1 !

@jk-
Copy link

jk- commented Mar 31, 2015

really good idea! +1

@yneves
Copy link

yneves commented Mar 31, 2015

best idea ever +1

@jrhite
Copy link
Contributor Author

jrhite commented Apr 1, 2015

@XhmikosR I just reverted the package.json version change and rebased to the latest code. Should be good to go.

Cheers!

@@ -139,3 +139,31 @@ Type: `Boolean`
Default: false

Pass this flag if you don't care about full compliance with Internet Explorer 6-8 quirks.

## mangleProperties
Type: `Boolean`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs 2 tailing spaces for a new line for all the newly added types.

…perty name mangling functionality, the ability to pass files containing property and variable name exceptions and the ability to use a cache to coordinate symbol mangling across multiple calls to uglify.

See uglifyjs v2.4.18 https://www.npmjs.com/package/uglify-js for more info.
@jrhite
Copy link
Contributor Author

jrhite commented Apr 2, 2015

@XhmikosR good eye again! (uggh...MD requires 2 extra spaces like that...still learning it :-) )

I went ahead and add the 2 trailing spaces to all the new options in docs/uglify-options.md. I also fixed some of the older options that were missing this too.

Checked in and rebased. Thanks!

XhmikosR added a commit that referenced this pull request Apr 2, 2015
Incorporate uglify's new object property mangling capabilities
@XhmikosR XhmikosR merged commit fb0f29a into gruntjs:master Apr 2, 2015
@XhmikosR
Copy link
Member

XhmikosR commented Apr 2, 2015

Thanks!

@jrhite
Copy link
Contributor Author

jrhite commented Apr 2, 2015

Thanks!

@XhmikosR when/how will this make it to the npm repo? it will be version 0.8.2, correct?

@XhmikosR
Copy link
Member

XhmikosR commented Apr 2, 2015

I don't make the releases myself so when @vladikoff thinks it's OK :P

Though, perhaps we could wait a couple of days in case we merge some of the other PRs too.

@jrhite
Copy link
Contributor Author

jrhite commented Apr 2, 2015

Ah, got it ok. Thanks...

No big rush here, but the sooner the better of course! :-)

On Thu, Apr 2, 2015 at 12:28 PM, XhmikosR [email protected] wrote:

I don't make the releases myself so when @vladikoff
https://github.com/vladikoff thinks it's OK :P

Though, perhaps we could wait a couple of days in case we merge some of
the other PRs too.


Reply to this email directly or view it on GitHub
#312 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants