Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about Issue #5241 #5309

Merged
merged 7 commits into from
Mar 8, 2025
Merged

Conversation

WwhdsOne
Copy link
Contributor

@WwhdsOne WwhdsOne commented Mar 4, 2025

docs:add docs about "ref to reference unused messages for openapi.json inclusion"

Fixes #5241

WwhdsOne added 4 commits March 2, 2025 23:17
The previous installation guide relied on tools.go for tracking dependencies.
This update replaces it with the new tool directive introduced in Go 1.24.

Fixes grpc-ecosystem#5254
Copy link
Contributor Author

@WwhdsOne WwhdsOne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your reminders and help. I think your version is much better.

@WwhdsOne WwhdsOne requested a review from johanbrandhorst March 6, 2025 11:46
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this looks much better. Could we move this file into docs/docs/mapping as well and rename it to using_ref_with_responses.md?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally intended the naming to have a bit of a connection with the issue title, but it seems that your naming is more appropriate for a document.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename is now .md.md 😬. Drop one of them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh... sorry about that

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanbrandhorst johanbrandhorst merged commit e02fb22 into grpc-ecosystem:main Mar 8, 2025
14 checks passed
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add example of using ref to reference unused messages for openapi.json inclusion
2 participants