Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Foundation.swift for cocoa pods #103

Merged
merged 3 commits into from
Oct 26, 2024
Merged

fix: update Foundation.swift for cocoa pods #103

merged 3 commits into from
Oct 26, 2024

Conversation

TheRogue76
Copy link
Contributor

Bit of a doozy, but basically, when it comes to SPM, the GRMustacheKeyAccess is a package that you import, but when it comes to Cocoapods, this is already bundled next to it and is NOT a separate package, so when you call import, it will fail, which means you can't build when using cocoa pods.

This PR adds a check to see if that even exists before trying to import it, addressing the issue for both SPM and Cocoapods (tried both locally but feel free to try as well)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@TheRogue76 TheRogue76 changed the title fix: Update Foundation.swift for cocoa pods fix: update Foundation.swift for cocoa pods Oct 18, 2024
@TheRogue76
Copy link
Contributor Author

@fumito-ito can you check this as well?

@fumito-ito
Copy link
Collaborator

@TheRogue76 Thanks for your PR. However, I encountered an error when running pod lib lint --allow-warnings on my macOS. The error message is as follows:

NOTE  | [iOS] xcodebuild:  clang: error: SDK does not contain 'libarclite' at the path '/Applications/Xcode-16.0.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/arc/libarclite_iphonesimulator.a'; try increasing the minimum deployment target

It seems similar to this issue: CocoaPods/CocoaPods#11839.

@TheRogue76
Copy link
Contributor Author

@fumito-ito Interesting. I will try to find some time this weekend / tomorrow and try seeing what is going on and report back. Seems like a removed dependency on newer tool chains.

@TheRogue76
Copy link
Contributor Author

TheRogue76 commented Oct 25, 2024

Ok @fumito-ito It appears that the matter is due to Xcode deprecating the older targets libarclite. As mentioned by Apple here Bumping the target to iOS 11 is now a requirement for using cocoa pods with the require_arc. I am bumping it on the pod file as well in this PR just to be in sync. Let me know your thoughts and if you want me to bump the SPM one as well. I also bumped the Swift Version to 5.9 because Xcode 15 is the oldest version that can actually send builds to App Store Connect now, and all older versions are defunct
Screenshot 2024-10-25 at 11 22 23

@fumito-ito
Copy link
Collaborator

Thanks @TheRogue76 . I believe raising the target is a reasonable change. I will update the SPM target, but I will create a separate PR for that myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants