Skip to content

[WIP] Add simple cycles algorithm #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[WIP] Add simple cycles algorithm #33

wants to merge 2 commits into from

Conversation

phyrwork
Copy link
Contributor

@phyrwork phyrwork commented Oct 7, 2018

Depends on #26

Test cases for

  • Simple cycle
  • Isolated strongly connected components
  • Connected strongly connected components

@phyrwork
Copy link
Contributor Author

Do not merge! This implementation is buggy. I will update the PR at some point.

@clue clue changed the title Add simple cycles algorithm [WIP] Add simple cycles algorithm Oct 11, 2018
@jp928
Copy link

jp928 commented Nov 14, 2019

@phyrwork
Do you mind to share what is the bug you mentioned?
I wish I could help.

@clue
Copy link
Member

clue commented Feb 19, 2020

@phyrwork Thank you for filing this PR and for your patience! 👍 This PR is currently marked as WIP, are you planning to update this again?

I'd first like to get a maintenance release out to bring this library up to date before introducing any additional algorithms. Once this is done, I'm looking forward to merging more of these algorithms, so I hope you're still interested in getting this merged then :shipit:

Again thank you for your valuable contribution! I understand this long wait time can be frustrating, so rest assured I'll try to get these intermediary release out as soon as time permits (this project doesn't currently get any sponsoring, so this happens mostly in my spare free time) and will then look into this PR again in more depth! 👍

@clue clue deleted the branch graphp:master October 30, 2022 13:49
@clue clue closed this Oct 30, 2022
@SimonFrings
Copy link
Contributor

This ticket got automatically closed after renaming the master branch to 0.9.x. We're not sure of the exact reason for this, it seems like it had nothing to do with the fact to merge this PR into the old master branch, other tickets with the same situation were left untouched.

This pull request is open for quite a while now and didn't receive any updates since, this is why I suggest we leave this closed for now. If this topic is still relevant and needs some further investigation, we can always reopen it in the future and take another look 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants