Annotate throttled profiles #3956
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Feb 28, 2025
| @@ -311,6 +325,8 @@ type InMemoryProfile struct { | |||
| DefaultSampleType int64 | |||
|
|
|||
| Samples Samples | |||
|
|
|||
| Annotations []string | |||
There was a problem hiding this comment.
In theory we could achieve the same thing with just using the Comments field above in L322.
I guess comment strings would be in the string table, unsure if that is a good or a bad thing.
I think if we would go for a separate type/field, I think we should make it Key,Value, because that feels more extensible to me than a []string,
There was a problem hiding this comment.
if we go with this, maybe at some point we can stop exploiting build Ids for github integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3879 and #3914, distributors reject profiles when an externally controlled ingest limit is reached.
This change annotates the few profiles that are let through in this state, so that users of the profiling data can be made aware that data is being rejected. The information is stored in an extra column in the parquet table, and is applied to v1 and v2 read and write paths.
A few things are still not finished, namely: