Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parse_json template function #3929

Merged
merged 11 commits into from
Feb 20, 2024
Merged

Add parse_json template function #3929

merged 11 commits into from
Feb 20, 2024

Conversation

KarimDarwish
Copy link
Contributor

@KarimDarwish KarimDarwish commented Feb 20, 2024

What this PR does

Adds a jinja2 template function that performs json.loads and parses a string into a json object so that e.g. b64encoded json objects can be fully used

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@KarimDarwish KarimDarwish requested a review from a team as a code owner February 20, 2024 13:49
@KarimDarwish KarimDarwish requested a review from a team February 20, 2024 13:49
@CLAassistant
Copy link

CLAassistant commented Feb 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution @KarimDarwish!

LGTM 👍

@KarimDarwish
Copy link
Contributor Author

Thanks @joeyorlando, I cannot view the results of the failing E2E test. Is it failing for unrelated reasons or because of my change?

@joeyorlando
Copy link
Contributor

Thanks @joeyorlando, I cannot view the results of the failing E2E test. Is it failing for unrelated reasons or because of my change?

unrelated reasons. The e2e CI job will not run on forked PRs (something that is known that we need to address).

Your changes shouldn't have any effect on the e2e tests.

@joeyorlando joeyorlando merged commit 2a46e4f into grafana:dev Feb 20, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants