Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When team is removed do not delete webhooks belonging to it #3873

Merged
merged 9 commits into from
Feb 15, 2024

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Feb 9, 2024

What this PR does

When a team is deleted webhooks belonging to that team will be marked as having no team instead of the webhook being deleted.

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@mderynck mderynck added the pr:no public docs Added to a PR that does not require public documentation updates label Feb 9, 2024
@mderynck mderynck marked this pull request as ready for review February 14, 2024 18:37
@mderynck mderynck requested a review from a team February 14, 2024 18:37
Copy link
Contributor

@matiasb matiasb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add a test?

@mderynck mderynck added this pull request to the merge queue Feb 15, 2024
Merged via the queue into dev with commit 617146f Feb 15, 2024
21 checks passed
@mderynck mderynck deleted the mderynck/keep-webhooks-on-team-delete branch February 15, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants