Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change email templating to not wrap user defined templates #3862

Merged
merged 5 commits into from
Feb 9, 2024

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Feb 8, 2024

What this PR does

Change email notification templates to not wrap the user template in a fixed body. Info has been moved to a footer. The title now also matches the template from the user exactly and will only get a default message if the user template result is empty.
Example:

Screenshot from 2024-02-08 12-16-38

Which issue(s) this PR fixes

#3857

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@mderynck mderynck added the pr:no public docs Added to a PR that does not require public documentation updates label Feb 8, 2024
@mderynck mderynck marked this pull request as ready for review February 8, 2024 21:43
@mderynck mderynck requested a review from a team February 8, 2024 21:43
@mderynck mderynck enabled auto-merge February 9, 2024 18:53
@mderynck mderynck added this pull request to the merge queue Feb 9, 2024
Merged via the queue into dev with commit aebd98b Feb 9, 2024
21 checks passed
@mderynck mderynck deleted the mderynck/remove-email-template-wrapper branch February 9, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants