Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix posting Slack message when route is deleted #3702

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

vstpme
Copy link
Member

@vstpme vstpme commented Jan 17, 2024

What this PR does

Fixes #3646

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@vstpme vstpme added the pr:no public docs Added to a PR that does not require public documentation updates label Jan 17, 2024
@vstpme vstpme changed the title Fix no channel filter scenario in AlertShootingStep Fix posting Slack message when route is deleted Jan 17, 2024
@vstpme vstpme force-pushed the vadimkerr/fix-3646 branch 2 times, most recently from 0ff331d to c873638 Compare January 17, 2024 12:40
@vstpme vstpme force-pushed the vadimkerr/fix-3646 branch from c873638 to 3c2c8ea Compare January 17, 2024 12:46
@vstpme vstpme marked this pull request as ready for review January 17, 2024 12:46
@vstpme vstpme requested a review from a team January 17, 2024 12:46
@joeyorlando joeyorlando added this pull request to the merge queue Jan 17, 2024
Merged via the queue into dev with commit 6c248ed Jan 17, 2024
@joeyorlando joeyorlando deleted the vadimkerr/fix-3646 branch January 17, 2024 13:09
iskhakov pushed a commit that referenced this pull request Feb 20, 2024
# What this PR does

Fixes #3646

## Checklist

- [x] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
3 participants