Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup one-at-a-time lock for sync_organization tasks #3612

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Jan 3, 2024

Related to https://github.com/grafana/support-escalations/issues/8844

Queuing multiple sync_organization tasks for the same org could lead to parallel running of the sync task for the same organization, potentially creating duplicated entries and/or generating multiple unneeded API calls. This prevents running an organization sync while there is a sync for that same org in progress.

@matiasb matiasb added the pr:no public docs Added to a PR that does not require public documentation updates label Jan 3, 2024
@matiasb matiasb marked this pull request as ready for review January 3, 2024 19:24
@matiasb matiasb requested a review from a team January 3, 2024 19:24
@matiasb matiasb marked this pull request as draft January 3, 2024 20:23
@matiasb matiasb marked this pull request as ready for review January 3, 2024 20:52
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! 👍

@matiasb matiasb added this pull request to the merge queue Jan 4, 2024
Merged via the queue into dev with commit 181d5d5 Jan 4, 2024
@matiasb matiasb deleted the matiasb/one-sync-at-a-time branch January 4, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants