Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change service account auth to use instance id instead #3435

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Change service account auth to use instance id instead #3435

merged 4 commits into from
Nov 28, 2023

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Nov 27, 2023 •
edited
Loading

What this PR does

Change GrafanaServiceAccountAuth to use instance ID header in cloud instead of slugs.

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@mderynck mderynck added the pr:no public docs Added to a PR that does not require public documentation updates label Nov 27, 2023
@mderynck mderynck marked this pull request as ready for review November 27, 2023 20:37
@mderynck mderynck requested a review from a team November 27, 2023 20:37
@mderynck mderynck added this pull request to the merge queue Nov 28, 2023
Merged via the queue into dev with commit e9f2178 Nov 28, 2023
@mderynck mderynck deleted the mderynck/service-token-instance-id branch November 28, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matiasb matiasb matiasb approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mderynck @matiasb