Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more logging info on alert creation #3392

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Add more logging info on alert creation #3392

merged 3 commits into from
Nov 21, 2023

Conversation

mderynck
Copy link
Contributor

@mderynck mderynck commented Nov 21, 2023 •
edited
Loading

What this PR does

Add alert receive channel id when logging to make it easier to trace grouping

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@mderynck mderynck added the pr:no public docs Added to a PR that does not require public documentation updates label Nov 21, 2023
@mderynck mderynck marked this pull request as ready for review November 21, 2023 01:43
@mderynck mderynck requested a review from a team November 21, 2023 01:43
@joeyorlando joeyorlando added this pull request to the merge queue Nov 21, 2023
Merged via the queue into dev with commit b3583cd Nov 21, 2023
@joeyorlando joeyorlando deleted the mderynck/improve-alert-creation-logging branch November 21, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeyorlando joeyorlando joeyorlando approved these changes

Assignees
No one assigned
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mderynck @joeyorlando