Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish user settings and warnings #2425

Merged
merged 14 commits into from
Jul 17, 2023
Merged

Polish user settings and warnings #2425

merged 14 commits into from
Jul 17, 2023

Conversation

iskhakov
Copy link
Contributor

@iskhakov iskhakov commented Jul 5, 2023

What this PR does

  • users table: added warnings: No default notifications set, No important notifications set
  • users table: removed warnings when messenger is not configured (e.g. telegram channels are not connected -> no need to show telegram warning in users table)
  • users table: moved current user to first place
  • user profile: cleaned up and added hints to notification channel connectors
  • user profile: cleaned up and added hints to calendar sync
  • chatops-slack: cleaned up and added hints to slack settings

fixes #2418

Which issue(s) this PR fixes

Checklist

  • Unit, integration, and e2e (if applicable) tests updated
  • Documentation added (or pr:no public docs PR label added if not required)
  • CHANGELOG.md updated (or pr:no changelog PR label added if not required)

@iskhakov iskhakov requested review from a team July 5, 2023 06:40
@iskhakov iskhakov added the pr:no public docs Added to a PR that does not require public documentation updates label Jul 5, 2023
@iskhakov iskhakov merged commit 8367a1e into dev Jul 17, 2023
@iskhakov iskhakov deleted the iskhakov/fix-user-warnings branch July 17, 2023 10:35
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does

* users table: added warnings: No default notifications set, No
important notifications set
* users table: removed warnings when messenger is not configured (e.g.
telegram channels are not connected -> no need to show telegram warning
in users table)
* users table: moved current user to first place
* user profile: cleaned up and added hints to notification channel
connectors
* user profile: cleaned up and added hints to calendar sync
* chatops-slack: cleaned up and added hints to slack settings

fixes #2418

## Which issue(s) this PR fixes

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
2 participants