Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed notification title and subtitle; removed body #2027

Merged
merged 13 commits into from
May 26, 2023
+32 −24
Merged

changed notification title and subtitle; removed body #2027

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b52a4ed
changed notification title and subtitle; removed body
imtoori May 25, 2023
a8e8baf
update changelog
imtoori May 25, 2023
6f4b9b7
fix title
imtoori May 25, 2023
571a6dd
fix lint
imtoori May 25, 2023
2780bba
fix lint
imtoori May 25, 2023
f19a40a
fix lint
imtoori May 25, 2023
0f65a18
fix alert title
imtoori May 26, 2023
e4cc45d
fix string construction
imtoori May 26, 2023
cb65242
fix lint
imtoori May 26, 2023
3a33b45
fix test
imtoori May 26, 2023
088ba31
Update CHANGELOG.md
imtoori May 26, 2023
29f31af
emojize all subtitle
imtoori May 26, 2023
84321d8
Merge branch 'dev' into imtoori/notificationTitle
joeyorlando May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix string construction
@imtoori
imtoori committed May 26, 2023

Verified

This commit was signed with the committer’s verified signature.
rezkiy37 Michael (Mykhailo) Kravchenko
GPG key ID: 5D8ECF07E1E2AC32
Verified
Learn about vigilant mode
commit e4cc45d0b9e8c67504d1004ae546cac996d9582d
4 changes: 2 additions & 2 deletions engine/apps/mobile_app/alert_rendering.py
View file
Original file line number Diff line number Diff line change
@@ -29,8 +29,8 @@ def get_push_notification_subtitle(alert_group):

alert_status = f"Status: {status_verbose}, alerts: {alerts_count_str}"

subtitle = f"#{alert_group.inside_organization_number} {alert_title}\n"
subtitle = (f"#{alert_group.inside_organization_number} {alert_title}\n"
+emojize(f"via {alert_group.channel.short_name}", use_aliases=True)
+f"\n{alert_status}"
+f"\n{alert_status}")

return subtitle