Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_default fields to templates, remove WritableSerialiserMethodFi… #1759

Merged
merged 8 commits into from
Apr 18, 2023
Prev Previous commit
Next Next commit
Clean up
iskhakov committed Apr 17, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit 4233c2ea6ccac96770aee990f6ebe3441f7c9c49
19 changes: 1 addition & 18 deletions engine/apps/api/serializers/alert_receive_channel.py
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@
from jinja2 import TemplateSyntaxError
from rest_framework import serializers
from rest_framework.exceptions import ValidationError
from rest_framework.fields import SerializerMethodField, SkipField, get_error_detail, set_value
from rest_framework.fields import SerializerMethodField, set_value
from rest_framework.settings import api_settings

from apps.alerts.grafana_alerting_sync_manager.grafana_alerting_sync import GrafanaAlertingSyncManager
@@ -246,23 +246,6 @@ def to_internal_value(self, data):

ret = OrderedDict()
errors = OrderedDict()
fields = self._writable_fields

for field in fields:
validate_method = getattr(self, "validate_" + field.field_name, None)
primitive_value = field.get_value(data)
try:
validated_value = field.run_validation(primitive_value)
if validate_method is not None:
validated_value = validate_method(validated_value)
except ValidationError as exc:
errors[field.field_name] = exc.detail
except DjangoValidationError as exc:
errors[field.field_name] = get_error_detail(exc)
except SkipField:
pass
else:
set_value(ret, field.source_attrs, validated_value)

# handle updates for core templates
core_template_errors = self._handle_core_template_updates(data, ret)