Collection of bugs #1600
Merged
Collection of bugs #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ukochka
added
pr:no changelog
pr:no public docs
joeyorlando
reviewed
Mar 23, 2023
There was a problem hiding this comment.
Just some questions/thoughts/things you may want to consider:
/incidentswill be redirected to/alert-groups, correct?- is there any URL generation, for this route, happening on the backend that may need to be updated? (open question for the whole team)
plugin.jsonstill references the/incidentsroute. does that need to be updated as well?- might be worth adding a very small e2e test that asserts that going to
/incidentswill still redirect you to the proper page
teodosii
reviewed
Mar 28, 2023
| }, | ||
| path: getPath('incident'), | ||
| path: getPath('alert-groups'), |
There was a problem hiding this comment.
This one is plural, the other one was singular. Is this on purpose?
There was a problem hiding this comment.
Yes it is. We had inconsistency before, and I fixed couple of places to make it all consistent. We have page name like 'alert-groups' in plural and after it will be parameter {id}
teodosii
reviewed
Mar 28, 2023
| @@ -762,7 +760,7 @@ function AttachedIncidentsList({ | |||
| {alerts.map((incident) => { | |||
| return ( | |||
| <HorizontalGroup key={incident.pk} justify={'space-between'}> | |||
| <PluginLink query={{ page: 'incident', id: incident.pk }}> | |||
| <PluginLink query={{ page: 'alert-groups', id: incident.pk }}> | |||
There was a problem hiding this comment.
Same here, shouldn't be alert-group ?
teodosii
reviewed
Mar 28, 2023
| @@ -256,12 +256,12 @@ class IncidentPage extends React.Component<IncidentPageProps, IncidentPageState> | |||
| {incident.root_alert_group && ( | |||
| <Text type="secondary"> | |||
| Attached to{' '} | |||
| <PluginLink query={{ page: 'incident', id: incident.root_alert_group.pk }}> | |||
| <PluginLink query={{ page: 'alert-groups', id: incident.root_alert_group.pk }}> | |||
teodosii
approved these changes
Mar 29, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
vstpme
added a commit
that referenced
this pull request
Mar 30, 2023
Reverts #1600 as it makes Slack links not working correctly with the plugin UI.
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does
List of fixes:
- Incident word removed from the url to `/alert-groups` page and
`/alert-group/{id}`
- Incident word removed from other parts of UI (Maintenance page, Linked
alert groups, Templates)
- Sticky rotation form was fixed at Schedules (when you scroll down and
open Layer 1)
- Integrations linked to Escalations chains are displayed right after
loading the page
- Autoresolve condition link to Alert behaviour template
## Which issue(s) this PR fixes
#1490
#1489
#1486
---------
Co-authored-by: Joey Orlando <[email protected]>
Co-authored-by: Rares Mardare <[email protected]>
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
Reverts #1600 as it makes Slack links not working correctly with the plugin UI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
List of fixes:
/alert-groupspage and/alert-group/{id}Which issue(s) this PR fixes
#1490
#1489
#1486