1124 viewers are not allowed in rotations #1577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ukochka
added
the
pr:no public docs
teodosii
reviewed
Mar 20, 2023
CHANGELOG.md
Outdated
| @@ -15,6 +15,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| ### Changed | |||
|
|
|||
| - Updated wording in some Slack messages to use 'Alert Group' instead of 'Incident' ([1565](https://github.com/grafana/oncall/pull/1565)) | |||
| - Filtering for Editors/Admins was added to rotation form. It is not allowed to assign Viewer to rotation ([1577]<https://github.com/grafana/oncall/pull/1577>) | |||
There was a problem hiding this comment.
This should point to the GitHub issue not the PR itself. It should be #1124
teodosii
approved these changes
Mar 20, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
# What this PR does Added additional filtering for roles 0 and 1 for rodations. Only Editors and Admins are allowed to be in rotation ## Which issue(s) this PR fixes #1124
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Added additional filtering for roles 0 and 1 for rodations. Only Editors and Admins are allowed to be in rotation
Which issue(s) this PR fixes
#1124