fake-data generation script + fixes for django-silk and django-debug-toolbar #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyorlando
changed the title
joeyorlando
commented
Jan 13, 2023
| @@ -23,7 +23,7 @@ recurring-ical-events==0.1.16b0 | |||
| slack-export-viewer==1.0.0 | |||
| beautifulsoup4==4.8.1 | |||
| social-auth-app-django==3.1.0 | |||
| cryptography==39.0.0 | |||
| cryptography==38.0.4 # version 39.0.0 introduced an issue - https://stackoverflow.com/a/75053968/3902555 | |||
There was a problem hiding this comment.
version 39.0.0 does not work on Apple silicon Macs, version 38.0.4 does
joeyorlando
commented
Jan 13, 2023
| # the below two lines make it possible to use django-debug-toolbar inside of docker locally | ||
| # https://knasmueller.net/fix-djangos-debug-toolbar-not-showing-inside-docker | ||
| hostname, _, ips = socket.gethostbyname_ex(socket.gethostname()) | ||
| INTERNAL_IPS += [".".join(ip.split(".")[:-1] + ["1"]) for ip in ips] |
There was a problem hiding this comment.
this allows the django-debug-toolbar to work when running the backend inside of docker-compose
joeyorlando
commented
Jan 16, 2023
Comment on lines
+19
to
+20
| - [distutils.errors.CompileError: command '/usr/bin/clang' failed with exit code 1](#distutilserrorscompileerror-command-usrbinclang-failed-with-exit-code-1) | ||
| - [symbol not found in flat namespace '\_EVP_DigestSignUpdate'](#symbol-not-found-in-flat-namespace-_evp_digestsignupdate) |
There was a problem hiding this comment.
these were the two issues I was experiencing when running make run-backend-celery locally on an Apple Silicon Mac
joeyorlando
force-pushed
the
jorlando/fix-slow-rbac-permissions-query
branch
from
a4b120d to
96d0580
Compare
iskhakov
approved these changes
Jan 17, 2023
joeyorlando
changed the title
joeyorlando
force-pushed
the
jorlando/fix-slow-rbac-permissions-query
branch
from
9be5db2 to
d327f7f
Compare
don't call response.json() if there is no response body (ex. in the case of a response for a HEAD call)
local grafana docker-compose container
when trying to run the server/celery worker outside of docker on an M1 Mac
bump django-silk version to v5.0.3 (latest version)
- creating Grafana teams/users - creating calendar schedules with three 8h oncall shifts
joeyorlando
force-pushed
the
jorlando/fix-slow-rbac-permissions-query
branch
2 times, most recently
from
6982986 to
eaac9a7
Compare
joeyorlando
changed the title
3 tasks
joeyorlando
added a commit
that referenced
this pull request
Jan 25, 2023
# What this PR does Fixes slow internal`GET /schedules` endpoints. Using the fake-data generation script in #1128, I generated 65 calendar schedules in my local setup. This resulted in the following endpoint performance:  The responses which show ~76 queries were run on the latest `dev` branch. Responses w/ ~26 queries were run on this branch. Additionally: - add typing to a few methods in `apps/schedules/ical_utils.py` - document `apps/api/permissions/__init__.py:user_is_authorized` function ## Which issue(s) this PR fixes grafana/oncall-private#1552 ## Checklist - [ ] Tests updated - [ ] Documentation added - [ ] `CHANGELOG.md` updated Co-authored-by: Vadim Stepanov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Main stuff
django-debug-toolbarwhen being run indocker-composelocallyOther stuff
docker-composecontainer provisioning configurationdocker-compose, on an Apple silicon Macgrafana_plugin.helpers.client.APIClient.call_apiwhere it would callresponse.json()for all requests, regardless of whether or not the response actually contained data or notengine/settings/dev.py, properly setupdjango-silkand document the steps to use it locallyDEV_DEBUG_VIEW_SQL_QUERIESenv var, rather than having to uncomment out a section ofsettings/dev.pyWhich issue(s) this PR fixes
django-silkanddjango-debug-toolbarChecklist
CHANGELOG.mdupdated (N/A)