Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI bug related to time inputs for "current UTC time is in" range escalation policy step #3585

Closed
joeyorlando opened this issue Dec 19, 2023 · 4 comments
Assignees
Labels
bug Something isn't working more info needed

Comments

@joeyorlando
Copy link
Contributor

What went wrong?

What happened:
https://www.loom.com/share/15cb3e79af1f4c3cb2c5163d9440e074

What did you expect to happen:

  • when I type a valid value into the time range it should not show a red border
  • when I backspace the entire value I should not get a full page error

How do we reproduce it?

See demo video here

Grafana OnCall Version

v1.3.80

Product Area

Other

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response

@joeyorlando joeyorlando added the bug Something isn't working label Dec 19, 2023
@maskin25 maskin25 self-assigned this Jan 4, 2024
@maskin25
Copy link
Contributor

@joeyorlando it displays a red border because the value must be a multiple of 5 (see minuteStep param), should we disable this restriction, WDYT?

@joeyorlando
Copy link
Contributor Author

@maskin25 ohhh interesting. wonder if it's worthwhile adding a small note about that? (or at least giving validation feedback as to why the input is red/invalid).

github-merge-queue bot pushed a commit that referenced this issue Jan 12, 2024
# What this PR does

Fix several UI related bugs

## Which issue(s) this PR fixes


#3585
https://github.com/grafana/oncall-private/issues/2427

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
@maskin25
Copy link
Contributor

@joeyorlando FYI after discussion with @raphael-batte we decided to get rid of this restriction, will do this in the next iteration

iskhakov pushed a commit that referenced this issue Feb 20, 2024
# What this PR does

Fix several UI related bugs

## Which issue(s) this PR fixes


#3585
grafana/oncall-private#2427

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [ ] Documentation added (or `pr:no public docs` PR label added if not
required)
- [ ] `CHANGELOG.md` updated (or `pr:no changelog` PR label added if not
required)
@joeyorlando
Copy link
Contributor Author

closing as completed in #3659

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working more info needed
Projects
None yet
Development

No branches or pull requests

2 participants