Helm - Twilio fails validation unless all auth fields are provided

[njohnstone2]

What went wrong?

What happened:
the helm chart validation for Twilio requires all 3 auth fields to be provided, resulting in a validation error if any are not specified.

What did you expect to happen:

Either (TWILIO_API_KEY_SID + TWILIO_API_KEY_SECRET) or TWILIO_AUTH_TOKEN is required.

Oncall Env Variables defines two options for configuring Twilio Auth:

1. TWILIO_API_KEY_SID + TWILIO_API_KEY_SECRET
2. TWILIO_AUTH_TOKEN

It would be good if these fields were made optional so that Oncall does not require config that is never used

How do we reproduce it?

values.yaml

oncall:
  twilio:
    accountSid: "test-sid"
    existingSecret: "my-secret"
    authTokenKey: "auth-token-key"
    phoneNumberKey: "phone-key"
    verifySidKey: "verify-key"
    # apiKeySidKey: "api-sid-key"
    # apiKeySecretKey: "api-secret-key"

Create the values file above then attempt to do a helm install with only one of the twilio auth methods

helm install oncall grafana/oncall -f values.yaml

Grafana OnCall Version

v1.3.17

Product Area

Helm

Grafana OnCall Platform?

Kubernetes

User's Browser?

n/a

Anything else to add?

No response