Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove k6/experimental/browser #4161

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Remove k6/experimental/browser #4161

merged 2 commits into from
Jan 17, 2025

Conversation

mstoykov
Copy link
Contributor

@mstoykov mstoykov commented Jan 8, 2025

What?

Remove k6/experimental/browser

Why?

It was deprecated long ago and it is time to be removed.

Checklist

  • I have performed a self-review of my code.
  • I have added tests for my changes.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make tests) and all tests pass.
  • I have commented on my code, particularly in hard-to-understand areas.

Related PR(s)/Issue(s)

Closes #4130

@mstoykov mstoykov added this to the v0.57.0 milestone Jan 8, 2025
@mstoykov mstoykov requested a review from a team as a code owner January 8, 2025 14:43
@mstoykov mstoykov requested review from oleiade and codebien and removed request for a team January 8, 2025 14:43
@mstoykov mstoykov added the breaking change for PRs that need to be mentioned in the breaking changes section of the release notes label Jan 8, 2025
codebien
codebien previously approved these changes Jan 8, 2025
View reviewed changes
inancgumus
inancgumus approved these changes Jan 15, 2025
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@ankur22 ankur22 merged commit 0b8ec77 into master Jan 17, 2025
29 checks passed
@ankur22 ankur22 deleted the dropExperimentalBrowser branch January 17, 2025 12:20
@BrewTestBot BrewTestBot mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@oleiade oleiade oleiade approved these changes

@codebien codebien codebien approved these changes

Assignees
No one assigned
Labels
breaking change for PRs that need to be mentioned in the breaking changes section of the release notes
Projects
None yet
Milestone
v0.57.0
Development

Successfully merging this pull request may close these issues.

Remove deprecated k6/experimental/browser
5 participants
@mstoykov @inancgumus @oleiade @codebien @ankur22