-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move not public parts of the k6 API in internal package #4133
Conversation
36f8fb3
to
4cf561d
Compare
223ec99
to
92cd119
Compare
81c1a61
to
a193a0f
Compare
Please, any reviewer run the |
19bea63
to
5ee4772
Compare
Instead, I would expect an empty list here. Is it expected? 🤔 The reason should be a different starting point of |
@mstoykov We should also consider to lock master to prevent to rebase all the time. Can you rebase the last time and lock it, please? |
@codebien can you try again, please. Yeah unfortunately making changes to master makes this constantly move. And we did merge a bunch of stuff yesterday after I finally managed to get most of the final things doen. On locking master - I kind of prefer that I do not block everyone from being able to merge stuff, given this takes me 2-5 minutes to rebase. |
|
What?
Move a lot of k6 code under
internal
.This is done through some scripts that are also committed and will be removed after the final move.
Why?
Define k6 public API by moving everything else in
internal
.This is hopefully the first in multiple steps. This is the one that is the most brutforce and moves the most amount of code around.
Checklist
make lint
) and all checks pass.make tests
) and all tests pass.Related PR(s)/Issue(s)