-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated Plexus @Component annotations are removed #1398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etiennestuder
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
etiennestuder
requested changes
Sep 6, 2024
...-extension/extension/src/main/java/com/myorg/ConventionDevelocityMavenExtensionListener.java
Outdated
Show resolved
Hide resolved
...ntion-develocity-maven-extension/extension/src/main/resources/META-INF/plexus/components.xml
Outdated
Show resolved
Hide resolved
...us-build-caching-extension/src/main/java/com/gradle/QuarkusBuildCacheDevelocityListener.java
Outdated
Show resolved
Hide resolved
quarkus-build-caching-extension/src/main/resources/plexus/META-INF/components.xml
Outdated
Show resolved
Hide resolved
quarkus-build-caching-extension/src/main/resources/plexus/META-INF/components.xml
Outdated
Show resolved
Hide resolved
5d7e8c1
to
a8656d3
Compare
a8656d3
to
5bae80f
Compare
…elocity Shared sample
…Caching extension
5bae80f
to
a4dbcc9
Compare
@etiennestuder after having a shift in priorities, this is ready for review once more. |
Merging as it's the same changes as were made to CCUD Maven. There should be no surprises here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the deprecated
@Component
annotations from the Quarkus extension and Maven Convention Develocity extension sample. They have been replaced with a dedicated file atsrc/main/resources/META-INF/plexus/components.xml
instead.