Maven listener isn't called in shared sample

[erichaagdev]

This was missed when creating the shared build. It meant the listener was never called. I never encountered it because I always ran with -Ddevelocity.url=https://ge.solutions-team.gradle.com.

[github-actions]

Job	Requested goals	Build Tool Version	Build Outcome	Build Scan®
verification_maven-[object Object]	wrapper:wrapper	3.9.9	✅
verification_maven-[object Object]	clean verify	3.8.8	✅

Generated by gradle/develocity-actions

[etiennestuder]

LGTM, but I cannot assess the overall impact. I will rely on @erichaagdev having verified it works.

[etiennestuder]

@erichaagdev do we need to do a similar change for the shared-plugin-extension ?

[etiennestuder]

LGTM, but I cannot assess the overall impact. I will rely on @erichaagdev having verified it works.

I meant the non-shared convention extension.

[jprinet]

LGTM, I could test that locally!
Great fast work Eric 👍

[erichaagdev]

@etiennestuder it only is a problem in the shared sample.

In the standalone Maven sample, it is built with Maven and the plexus-component-metadata plugin generates the component.xml file as part of the build.

This isn't the case in the shared sample, because it is built with Gradle.

Now that I think about it, this is actually redundant:

develocity-build-config-samples/convention-develocity-shared/convention-develocity-maven-extension/src/main/java/com/myorg/ConventionDevelocityMavenExtensionListener.java

Lines 13 to 17 in 0ceecfb

	@Component(
	role = DevelocityListener.class,
	hint = "convention-develocity-maven-extension",
	description = "Configures the Develocity Maven extension for com.myorg"
	)

We don't include it in the extension built by Gradle in the BVS repo.