Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Make easier to work with in node #56

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

benogle
Copy link

@benogle benogle commented Oct 28, 2014

In master, usage in node is super painful:

global.esprima = require('polymer-expressions/third_party/esprima/esprima').esprima
{PolymerExpressions} = require 'polymer-expressions/src/polymer-expressions'

This fixes by

  • Pointing main at ./src/polymer-expressions.js
  • Uses require when it's available

With this PR, it's

{PolymerExpressions} = require 'polymer-expressions'

@benogle
Copy link
Author

benogle commented Oct 29, 2014

Ok, updated.

@ebidel
Copy link

ebidel commented Nov 4, 2014

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

@ebidel ebidel added cla: no and removed cla: yes labels Nov 4, 2014
@benogle
Copy link
Author

benogle commented Nov 4, 2014

Signed.

@justinfagnani
Copy link
Contributor

I'm working on a major rewrite in the 2.0-preview branch, which is easy to import in node. I think it's best if we close this PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants