This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Add Closure compiler externs and a concrete EventType enum. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…radio-button. Note that the externs are dependent on the Polymer externs in the pull request at Polymer/polymer#769.
jklein24
added a commit
to jklein24/paper-checkbox
that referenced
this pull request
Oct 14, 2014
…. This is dependent on the externs for paper-radio-button (googlearchive/paper-radio-button#8) and Polymer (Polymer/polymer#769).
|
Let's smush these into a single |
|
Same reasoning as googlearchive/paper-checkbox#18: "Unfortunately, we can't combine these into one file since the eventtype file is not an @externs file. Dependencies are managed differently between externs and non-externs, so I believe they'll need to stay separated." |
nevir
added a commit
that referenced
this pull request
Oct 16, 2014
Add Closure compiler externs and a concrete EventType enum.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the externs are dependent on the Polymer externs in the pull request at Polymer/polymer#769.