Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

added a demo page for paper-focusable #3

Merged
merged 5 commits into from
Jul 7, 2014
Merged

added a demo page for paper-focusable #3

merged 5 commits into from
Jul 7, 2014

Conversation

WillsonSmith
Copy link
Contributor

created a demo with active, pressed, focused, disabled, and toggle states. I copied the layout of the paper-button demo to get the structure of this document.

@WillsonSmith WillsonSmith deleted the pull-request-add-demo branch July 5, 2014 00:12
@WillsonSmith WillsonSmith restored the pull-request-add-demo branch July 5, 2014 00:12
@WillsonSmith WillsonSmith reopened this Jul 5, 2014
@ebidel
Copy link

ebidel commented Jul 5, 2014

Before this PR can be merged, please sign the CLA. See the CONTRIBUTING guide.

@WillsonSmith
Copy link
Contributor Author

Oops! I've now signed the CLA via the electronic signing form.

@ebidel
Copy link

ebidel commented Jul 5, 2014

Thanks for signing the CLA!

<script src="../platform/platform.js"></script>

<link href="../font-roboto/roboto.html" rel="import">
<!--<link href="../bower_components/core-icons/core-icons.html" rel="import">-->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this line?

Use of this source code is governed by a BSD-style
license that can be found in the LICENSE file.

contribution by Willson Smith
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add you here instead? http://polymer.github.io/CONTRIBUTORS.txt

@morethanreal
Copy link
Contributor

lgtm

morethanreal pushed a commit that referenced this pull request Jul 7, 2014
added a demo page for paper-focusable
@morethanreal morethanreal merged commit 2345e76 into googlearchive:master Jul 7, 2014
@ebidel
Copy link

ebidel commented Jul 10, 2014

I'm probably missing something, but the new demo page doesn't seem to do anything for me: http://www.polymer-project.org/components/paper-focusable/demo.html

@WillsonSmith
Copy link
Contributor Author

The text isn't rendering in the object there (its in the source). I can't see what's causing it though. If you look here: http://willsonsmith.com/paper-focusable/demo.html It seems to be working okay? Although, the demo on my website there doesn't seem to have the #shadow-root inside of the <paper-focusable>, unlike the demo on the polymer-project website.

edit: firefox doesn't seem to be rendering anything within the element? http://cl.ly/image/2a1t3H2a253t

@ebidel
Copy link

ebidel commented Jul 10, 2014

I think this is because a <template> was added that creates shadow dom. @morethanreal?

@morethanreal
Copy link
Contributor

Sorry, that was my bug. Fixed in 856e3cc

@WillsonSmith WillsonSmith deleted the pull-request-add-demo branch July 10, 2014 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants