fix: versioning-strategy field incorrect #2450
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK I found out the hard way internals don't use
--versioning-strategy VersioningStrategyType Override method of determining SemVer version bumps based on commits. Defaults to default https://github.com/googleapis/release-please/blob/main/docs/cli.md |
This was referenced Dec 11, 2024
|
Ping, curious if we can get this fixed / get an update on this? |
chingor13
requested changes
Feb 20, 2025
| @@ -24,7 +24,7 @@ | |||
| "description": "Configuration option for the prerelease versioning strategy. If prerelease strategy used and type set, will set the prerelease part of the version to the provided value in case prerelease part is not present.", | |||
| "type": "string" | |||
| }, | |||
| "versioning": { | |||
| "versioning-strategy": { | |||
There was a problem hiding this comment.
versioning is the correct field in the config. The command line argument is versioning-strategy which is irrelevant to this schema.
| "changelog-sections": true, | ||
| "release-as": true, | ||
| "skip-github-release": true, | ||
| "draft": true, | ||
| "prerelease": true, | ||
| "prerelease-type": true, |
There was a problem hiding this comment.
This one looks ok to add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 hi (one of a couple different incoming prs) this is an easy one:
https://github.com/googleapis/release-please/blob/main/src/bin/release-please.ts#L304
The field is "versioning-strategy" not "versioning", also missing "prerelease-type".