fix: make atexit registration conditional on background transport #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The background transport fails on Python 3.12 when working with gRPC in case there are messages in the queue when the Python interpreter exits. Making the registration of the atexit callback conditional so that users can circumvent this error by explicitly stopping the logging when their application terminates. We can consider making the default value depend on the Python version at runtime, but it was decided to not change the default behaviour, regardless of the Python version. Fixes googleapis#850 and googleapis#855 (if users would setup the logging disabling the atexit hook)
product-auto-label
bot
added
size: s
Ack. Is there any way I can help @gkevinzheng ? This is blocking the migration of our AppEngine-deployed app to 3.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The background transport fails on Python 3.12 when working with gRPC in case there are messages in the queue when the Python interpreter exits. Making the registration of the atexit callback conditional so that users can circumvent this error by explicitly stopping the logging when their application terminates.
We can consider making the default value depend on the Python version at runtime, but it was decided to not change the default behaviour, regardless of the Python version.
Fixes #850 and #855 (if users would setup the logging disabling the atexit hook).