-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(all): restore go 1.22 in go.mod #3011
Conversation
fixes: 3009
I don't think we can make this change because of our dependencies have a patch level specified in thier go.mod. |
In Kokoro, it fails the go.mod diff check in latest-version (below).
|
The dependency that forces
But unfortunately, that library has a dependency that is NOT under our control:
|
I've created a minimal repro: https://github.com/matthewhartstonge/exp-gomod-toolchain-resolution But yeah, the issue does seem to be the Setting |
To me this is a Go ecosystem class of issue. I think this feedback on managing go versions should likely be reported upstream to the Go project if it has not already. |
@matthewhartstonge I'll investigate the possibility of setting |
@quartzmo That talks to the toolchain aspect, but the Go version part is likely a seperate and maybe even more contentious topic. |
fixes: #3009