Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update smoke tests. #333

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Update smoke tests. #333

merged 1 commit into from
Feb 18, 2022

Conversation

jburger424
Copy link
Contributor

@jburger424 jburger424 commented Feb 18, 2022

Allow numAdShifts to range from 3 - 5 to reduce flakiness.
Temporarily disable error smoke test until GPT fix reaches production.

@jburger424 jburger424 requested a review from avparmar February 18, 2022 16:52
Copy link
Collaborator

@avparmar avparmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Jon.

@jburger424 jburger424 merged commit 23293c3 into googleads:master Feb 18, 2022
@jburger424 jburger424 deleted the fix-tests branch February 18, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants