Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use global URL instead of node url module #325

Merged
merged 1 commit into from
Jan 7, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ const {auditNotApplicable} = require('../messages/common-strings');
const {Audit} = require('lighthouse');
const {getAttributableUrl} = require('../utils/tasks');
const {isAdScript} = require('../utils/resource-classification');
const {URL} = require('url');

const UIStrings = {
/* Title of the audit */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const {auditNotApplicable} = require('../messages/common-strings');
const {Audit} = require('lighthouse');
const {getTimingsByRecord} = require('../utils/network-timing');
const {isAdTag} = require('../utils/resource-classification');
const {URL} = require('url');

const UIStrings = {
title: 'Minimal render-blocking resources found',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-plugin-publisher-ads/audits/async-ad-tags.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const NetworkRecords = require('lighthouse/lighthouse-core/computed/network-reco
const {auditNotApplicable} = require('../messages/common-strings');
const {Audit} = require('lighthouse');
const {isAdTag, isStaticRequest} = require('../utils/resource-classification');
const {URL} = require('url');

const UIStrings = {
title: 'Ad tag is loaded asynchronously',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-plugin-publisher-ads/audits/duplicate-tags.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ const NetworkRequest = require('lighthouse/lighthouse-core/lib/network-request.j
const {auditNotApplicable} = require('../messages/common-strings');
const {Audit} = require('lighthouse');
const {containsAnySubstring} = require('../utils/resource-classification');
const {URL} = require('url');

const UIStrings = {
title: 'No duplicate tags found',
Expand Down
1 change: 0 additions & 1 deletion lighthouse-plugin-publisher-ads/audits/full-width-slots.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ const NetworkRecords = require('lighthouse/lighthouse-core/computed/network-reco
const {auditNotApplicable} = require('../messages/common-strings');
const {Audit} = require('lighthouse');
const {isAdRequest} = require('../utils/resource-classification');
const {URL} = require('url');

const UIStrings = {
title: 'Ad slots effectively use horizontal space',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ const NetworkRecords = require('lighthouse/lighthouse-core/computed/network-reco
const {auditNotApplicable} = require('../messages/common-strings');
const {Audit} = require('lighthouse');
const {isAdTag} = require('../utils/resource-classification');
const {URL} = require('url');

const UIStrings = {
title: 'Ad tag is loaded over HTTPS',
failureTitle: 'Load ad tag over HTTPS',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const {bucket} = require('../utils/array');
const {getTimingsByRecord} = require('../utils/network-timing');
const {isCacheable} = require('../utils/network');
const {isGoogleAds, getHeaderBidder} = require('../utils/resource-classification');
const {URL} = require('url');

/** @typedef {LH.Artifacts.NetworkRequest} NetworkRequest */
/** @typedef {LH.Gatherer.Simulation.NodeTiming} NodeTiming */
Expand Down
1 change: 0 additions & 1 deletion lighthouse-plugin-publisher-ads/computed/tag-load-time.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const ComputedMetric = require('lighthouse/lighthouse-core/computed/metrics/metr
const makeComputedArtifact = require('lighthouse/lighthouse-core/computed/computed-artifact.js');
const {getPageStartTime, getTagEndTime} = require('../utils/network-timing');
const {isImplTag} = require('../utils/resource-classification');
const {URL} = require('url');

// @ts-ignore
// eslint-disable-next-line max-len
Expand Down
1 change: 0 additions & 1 deletion lighthouse-plugin-publisher-ads/test/utils/array_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
const array = require('../../utils/array');
const {expect} = require('chai');
const {isGoogleAds} = require('../../utils/resource-classification');
const {URL} = require('url');

describe('array', () => {
describe('#count', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

const {expect} = require('chai');
const {isGoogleAds, isGptAdRequest, isImpressionPing, isGptTag, isGptImplTag, isAMPTag, isAMPAdRequest} = require('../../utils/resource-classification');
const {URL} = require('url');

describe('resource-classification', () => {
describe('#isGoogleAds', () => {
Expand Down
1 change: 0 additions & 1 deletion lighthouse-plugin-publisher-ads/utils/network-timing.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ const LoadSimulator = require('lighthouse/lighthouse-core/computed/load-simulato
const NetworkRecords = require('lighthouse/lighthouse-core/computed/network-records.js');
const PageDependencyGraph = require('lighthouse/lighthouse-core/computed/page-dependency-graph.js');
const {isAdRequest, isBidRequest, isImplTag, isImpressionPing} = require('./resource-classification');
const {URL} = require('url');

/** @typedef {LH.Artifacts.NetworkRequest} NetworkRequest */
/** @typedef {LH.Gatherer.Simulation.NodeTiming} NodeTiming */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
const bidderPatterns = require('./bidder-patterns');
const thirdPartyWeb = require('lighthouse/lighthouse-core/lib/third-party-web.js');
const {isCacheable} = require('../utils/network');
const {URL} = require('url');

/**
* Converts the given url to a URL, if it's not already a URL. Otherwise returns
Expand Down