Make ad-render-blocking-resources audit have display mode binary instead of numeric
#123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thouse-plugin into asi-adsense
jonkeller
commented
Sep 9, 2019
| @@ -74,7 +74,7 @@ class AdRenderBlockingResources extends RenderBlockingResources { | |||
| id: 'ad-render-blocking-resources', | |||
| title: str_(UIStrings.title), | |||
| failureTitle: str_(UIStrings.failureTitle), | |||
| scoreDisplayMode: 'numeric', | |||
| scoreDisplayMode: 'binary', | |||
There was a problem hiding this comment.
I also toyed with removing line 122 below, but it also did not make any visual difference.
Yeah, I don't think it makes any difference these days, more or less vestigial from when we wanted different indicators for audit state based on if it was a pass/fail or numerically-scored audit. Now its only use is maybe giving context on what range of scores are possible from an audit...but I don't know of anyone who actually uses binary/numeric for that. |
|
Ok, thanks Brendan! I'll move it from a Draft PR to a real one in that case. |
jburger424
approved these changes
Sep 10, 2019
warrengm
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the change, but there is no longer any visual difference between the two display modes, due to the somewhat-recent Lighthouse UI refresh.
Fixes #90