use global URL constructor instead of node 'url' module (#325)

googleads · Jan 7, 2022 · 957c02b · 957c02b
1 parent 8d6ad70
commit 957c02b
Show file tree

Hide file tree

Showing 12 changed files with 0 additions and 13 deletions.
diff --git a/lighthouse-plugin-publisher-ads/audits/ad-blocking-tasks.js b/lighthouse-plugin-publisher-ads/audits/ad-blocking-tasks.js
@@ -14,7 +14,6 @@ const {auditNotApplicable} = require('../messages/common-strings');
 const {Audit} = require('lighthouse');
 const {getAttributableUrl} = require('../utils/tasks');
 const {isAdScript} = require('../utils/resource-classification');
-const {URL} = require('url');
 
 const UIStrings = {
   /* Title of the audit */

diff --git a/lighthouse-plugin-publisher-ads/audits/ad-render-blocking-resources.js b/lighthouse-plugin-publisher-ads/audits/ad-render-blocking-resources.js
@@ -19,7 +19,6 @@ const {auditNotApplicable} = require('../messages/common-strings');
 const {Audit} = require('lighthouse');
 const {getTimingsByRecord} = require('../utils/network-timing');
 const {isAdTag} = require('../utils/resource-classification');
-const {URL} = require('url');
 
 const UIStrings = {
   title: 'Minimal render-blocking resources found',

diff --git a/lighthouse-plugin-publisher-ads/audits/async-ad-tags.js b/lighthouse-plugin-publisher-ads/audits/async-ad-tags.js
@@ -20,7 +20,6 @@ const NetworkRecords = require('lighthouse/lighthouse-core/computed/network-reco
 const {auditNotApplicable} = require('../messages/common-strings');
 const {Audit} = require('lighthouse');
 const {isAdTag, isStaticRequest} = require('../utils/resource-classification');
-const {URL} = require('url');
 
 const UIStrings = {
   title: 'Ad tag is loaded asynchronously',

diff --git a/lighthouse-plugin-publisher-ads/audits/duplicate-tags.js b/lighthouse-plugin-publisher-ads/audits/duplicate-tags.js
@@ -20,7 +20,6 @@ const NetworkRequest = require('lighthouse/lighthouse-core/lib/network-request.j
 const {auditNotApplicable} = require('../messages/common-strings');
 const {Audit} = require('lighthouse');
 const {containsAnySubstring} = require('../utils/resource-classification');
-const {URL} = require('url');
 
 const UIStrings = {
   title: 'No duplicate tags found',

diff --git a/lighthouse-plugin-publisher-ads/audits/full-width-slots.js b/lighthouse-plugin-publisher-ads/audits/full-width-slots.js
@@ -17,7 +17,6 @@ const NetworkRecords = require('lighthouse/lighthouse-core/computed/network-reco
 const {auditNotApplicable} = require('../messages/common-strings');
 const {Audit} = require('lighthouse');
 const {isAdRequest} = require('../utils/resource-classification');
-const {URL} = require('url');
 
 const UIStrings = {
   title: 'Ad slots effectively use horizontal space',

diff --git a/lighthouse-plugin-publisher-ads/audits/loads-ad-tag-over-https.js b/lighthouse-plugin-publisher-ads/audits/loads-ad-tag-over-https.js
@@ -17,8 +17,6 @@ const NetworkRecords = require('lighthouse/lighthouse-core/computed/network-reco
 const {auditNotApplicable} = require('../messages/common-strings');
 const {Audit} = require('lighthouse');
 const {isAdTag} = require('../utils/resource-classification');
-const {URL} = require('url');
-
 const UIStrings = {
   title: 'Ad tag is loaded over HTTPS',
   failureTitle: 'Load ad tag over HTTPS',

diff --git a/lighthouse-plugin-publisher-ads/audits/serial-header-bidding.js b/lighthouse-plugin-publisher-ads/audits/serial-header-bidding.js
@@ -23,7 +23,6 @@ const {bucket} = require('../utils/array');
 const {getTimingsByRecord} = require('../utils/network-timing');
 const {isCacheable} = require('../utils/network');
 const {isGoogleAds, getHeaderBidder} = require('../utils/resource-classification');
-const {URL} = require('url');
 
 /** @typedef {LH.Artifacts.NetworkRequest} NetworkRequest */
 /** @typedef {LH.Gatherer.Simulation.NodeTiming} NodeTiming */

diff --git a/lighthouse-plugin-publisher-ads/computed/tag-load-time.js b/lighthouse-plugin-publisher-ads/computed/tag-load-time.js
@@ -19,7 +19,6 @@ const ComputedMetric = require('lighthouse/lighthouse-core/computed/metrics/metr
 const makeComputedArtifact = require('lighthouse/lighthouse-core/computed/computed-artifact.js');
 const {getPageStartTime, getTagEndTime} = require('../utils/network-timing');
 const {isImplTag} = require('../utils/resource-classification');
-const {URL} = require('url');
 
 // @ts-ignore
 // eslint-disable-next-line max-len

diff --git a/lighthouse-plugin-publisher-ads/test/utils/array_test.js b/lighthouse-plugin-publisher-ads/test/utils/array_test.js
@@ -15,7 +15,6 @@
 const array = require('../../utils/array');
 const {expect} = require('chai');
 const {isGoogleAds} = require('../../utils/resource-classification');
-const {URL} = require('url');
 
 describe('array', () => {
   describe('#count', () => {

diff --git a/lighthouse-plugin-publisher-ads/test/utils/resource-classification_test.js b/lighthouse-plugin-publisher-ads/test/utils/resource-classification_test.js
@@ -14,7 +14,6 @@
 
 const {expect} = require('chai');
 const {isGoogleAds, isGptAdRequest, isImpressionPing, isGptTag, isGptImplTag, isAMPTag, isAMPAdRequest} = require('../../utils/resource-classification');
-const {URL} = require('url');
 
 describe('resource-classification', () => {
   describe('#isGoogleAds', () => {

diff --git a/lighthouse-plugin-publisher-ads/utils/network-timing.js b/lighthouse-plugin-publisher-ads/utils/network-timing.js
@@ -18,7 +18,6 @@ const LoadSimulator = require('lighthouse/lighthouse-core/computed/load-simulato
 const NetworkRecords = require('lighthouse/lighthouse-core/computed/network-records.js');
 const PageDependencyGraph = require('lighthouse/lighthouse-core/computed/page-dependency-graph.js');
 const {isAdRequest, isBidRequest, isImplTag, isImpressionPing} = require('./resource-classification');
-const {URL} = require('url');
 
 /** @typedef {LH.Artifacts.NetworkRequest} NetworkRequest */
 /** @typedef {LH.Gatherer.Simulation.NodeTiming} NodeTiming */

diff --git a/lighthouse-plugin-publisher-ads/utils/resource-classification.js b/lighthouse-plugin-publisher-ads/utils/resource-classification.js
@@ -15,7 +15,6 @@
 const bidderPatterns = require('./bidder-patterns');
 const thirdPartyWeb = require('lighthouse/lighthouse-core/lib/third-party-web.js');
 const {isCacheable} = require('../utils/network');
-const {URL} = require('url');
 
 /**
  * Converts the given url to a URL, if it's not already a URL. Otherwise returns