Fix cURL example #81
Merged
Fix cURL example #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a naming mixup in `oss-internship-2020/curl/CMakeLists.txt`, the necessary `WriteToMemory()` callback was not linked into the sandboxee, leading to a segfault in the sandboxee when trying to run the tests/examples. As another issue, cURL seems to call `sysinfo` and `rt_sigaction` in recent versions and with recent libc. Drive-by changes: - Use the SAPI status macros instead of manually checking `absl::Status` - Put tests in namespace - Some Google C++-style fixes - Start the mock test server only once per test suite Fixes #72 for cURL. Signed-off-by: Christian Blichmann <[email protected]>
happyCoder92
pushed a commit
that referenced
this pull request
May 4, 2022
PiperOrigin-RevId: 353812058 Change-Id: I500cab1c3f44ce24e321df3a3253710911feada9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a naming mixup in
oss-internship-2020/curl/CMakeLists.txt, thenecessary
WriteToMemory()callback was not linked into the sandboxee,leading to a segfault in the sandboxee when trying to run the
tests/examples.
As another issue, cURL seems to call
sysinfoandrt_sigactioninrecent versions and with recent libc.
Drive-by changes:
absl::StatusFixes #72 for cURL.
Signed-off-by: Christian Blichmann [email protected]