Emit non-type template args as part of forward decls #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change allows us to emit forward declarations to classes that are templated. For headers generated by the proto compiler this is sometimes necessary. Note: - This will only emit types for a single level of template instantiations. That is, template template arguments are not supported. - Typedefs only occurring in template arguments will be fully desugared and thus will not be available under their aliased name in the generated API code. This is consistent with the Python based generator (which does not emit these at all and relies on text extraction). Signed-off-by: Christian Blichmann <[email protected]>
happyCoder92
pushed a commit
that referenced
this pull request
May 4, 2022
PiperOrigin-RevId: 339616485 Change-Id: Iaa427e0aa5712f36ae1c176bffbaf00b2b342373
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows us to emit forward declarations to classes that are
templated. For headers generated by the proto compiler this is sometimes
necessary.
Note:
is, template template arguments are not supported.
and thus will not be available under their aliased name in the generated
API code. This is consistent with the Python based generator (which
does not emit these at all and relies on text extraction).
Signed-off-by: Christian Blichmann [email protected]