GDAL Raster to GeoTIFF workflow implementation #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented simple GTiff file parser to test sandboxed part of code on a real data, added unit tests. Need to improve the CMake file to make it work without specifying the absolute paths to libraries.
More flexible CMake file with variables Added logic to check whether proj.db exists and fetch it from the environment variable
Added instructions on how to build GDAL Sandbox using GDAL and PROJ build from sources Updated test data
Put duplicated code inside the transaction, which is used by both tests and raster_to_gtiff Removed <filesystem> header, reimplemented one of its utilities for file checking Code style changes Replaced .data() with .c_str() for std::string Updated README to show how to build both GDAL and PROJ inside the build folder and how to link them to the sandbox
Comments fix Changed sapi::StatusOr to absl::StatusOr Code changes according to new CStr(absl::string_view) constructor
|
|
||
| inline constexpr absl::string_view kTempFilePrefix = "temp_data"; | ||
| inline constexpr absl::string_view kFirstTestDataPath = | ||
| "../testdata/cea.tif"; |
There was a problem hiding this comment.
pass PROJECT_BINARY_DIR with an env var to the test and use a path relative to that
See: TEST_SRCDIR in sandboxed_api/sandbox2/CMakeLists.txt
Similar for temp file.
Added environment variables to remove relative paths from the code
happyCoder92
pushed a commit
that referenced
this pull request
May 4, 2022
PiperOrigin-RevId: 337856019 Change-Id: Ib1d9c5614f02da4df8d624f006f31ea09bb5c560
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic implementation of the workflow with sample sandbox policy, unit tests and command-line utility to re-create GTiff file inside the sandbox.