Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libarchive #62

Merged
merged 36 commits into from
Oct 8, 2020
Merged

Libarchive #62

merged 36 commits into from
Oct 8, 2020

Conversation

andreimedar
Copy link
Contributor

libarchive sandbox. The minitar example is implemented, which is a simplified "tar" comand line tool.

@andreimedar
created branch and libarchive directory
ed099de
@andreimedar
added libarchive submodule
ab8d8cb
@andreimedar
added some more examples
a6e0bb6
@andreimedar
added example rules to CMakeLists.txt
357fd5d
@andreimedar
small cleanup
617cc04
@andreimedar
added gitignore
e60c3ab
@andreimedar
corrected error inside CMakeLists
b5bde83
@andreimedar
added helper library
de27b90
@andreimedar
added a sandbox file and extracted the functions that will be sandboxed
56481b1
@andreimedar
small changes to cmake (wip trying to add head patch for libarchive)
48935a2
@andreimedar
added a part of the example code
9789eb6
@andreimedar
added extraction example to minitar
9ec90b7
@andreimedar
Added sandbox policy for extract function
7e24ee2
@andreimedar
Finished the create function of the tar example
6c9a26d
@andreimedar
added cleanup struct to remove temporary directory
c2c3f6b
@andreimedar
cleaned up some code. Fixed a bug where a temporary directory would b…
e0e0f1c 
…e deleted even when it was not created
@andreimedar
added .gitignore file
97cf3d7
@andreimedar
merged .gitmodules with upstream
388bcff
@andreimedar
added relative path cleanup using file::CleanPath
3052967
@andreimedar
Cleaned up the code files + added some comments
0625f30
@andreimedar
Reorganized project structure in order to make functions testable
eef5b8b
@andreimedar
Modified CMakeLists.txt indentation
b04d718
@andreimedar
renamed main project folder
e6e564f
@andreimedar
Added test helper class
267686a
@andreimedar
Added first basic test
7e6872e
@andreimedar
Added unit tests. Cleaned up the code and added comments. Added README
efe48cc
@andreimedar
Removed computer specific line in CMakeLists.txt
c5d44ea
@google-cla google-cla bot added the cla: yes CLA accepted label Oct 1, 2020
fluxchief
fluxchief reviewed Oct 1, 2020
View reviewed changes
Copy link
Collaborator

@fluxchief fluxchief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of comments, will take another look later :)

cblichmann
cblichmann requested changes Oct 6, 2020
View reviewed changes
cblichmann
cblichmann requested changes Oct 7, 2020
View reviewed changes
Copy link
Member

@cblichmann cblichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round :)

@cblichmann cblichmann merged commit 33bc36a into google:master Oct 8, 2020
happyCoder92 pushed a commit that referenced this pull request May 4, 2022
@copybara-github
Merge pull request #62 from andreimedar:libarchive
d11849c 
PiperOrigin-RevId: 336042102
Change-Id: I7b1ceaa794851c10e07dbdef4f4e37000edc25d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluxchief fluxchief fluxchief left review comments

@cblichmann cblichmann cblichmann approved these changes

Assignees
No one assigned
Labels
cla: yes CLA accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreimedar @cblichmann @fluxchief