Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibTIFF Sandbox #56

Merged
merged 49 commits into from
Dec 8, 2020
Merged

LibTIFF Sandbox #56

merged 49 commits into from
Dec 8, 2020

Conversation

alexelex
Copy link
Contributor

@alexelex alexelex commented Sep 23, 2020 •
edited
Loading

Adding LibTIFF Sandbox
sapi version LibTIFF using wrapper for variadic functions
4 Google Tests (for testing run ./test/tests from build)
1 example (run with ./example/sandboxed), made from raw_decode test in libtiff

@google-cla google-cla bot added the cla: yes CLA accepted label Sep 23, 2020
cblichmann
cblichmann requested changes Sep 24, 2020
View reviewed changes
fluxchief
fluxchief reviewed Sep 28, 2020
View reviewed changes
Copy link
Collaborator

@fluxchief fluxchief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - I left some comments. Note that for the SAPI functions you listed I started commenting with that you should remove them. In case you want to keep them and list them as "those functions are tested here", add comment explaining exactly that.

fluxchief
fluxchief reviewed Oct 1, 2020
View reviewed changes
fluxchief
fluxchief reviewed Oct 2, 2020
View reviewed changes
cblichmann
cblichmann requested changes Oct 6, 2020
View reviewed changes
fluxchief
fluxchief requested changes Oct 15, 2020
View reviewed changes
happyCoder92
happyCoder92 reviewed Oct 20, 2020
View reviewed changes
cblichmann
cblichmann requested changes Oct 28, 2020
View reviewed changes
@cblichmann cblichmann merged commit 6f8e758 into google:master Dec 8, 2020
happyCoder92 pushed a commit that referenced this pull request May 4, 2022
@copybara-github
Merge pull request #56 from alexelex:master
8902f99 
PiperOrigin-RevId: 346286713
Change-Id: Ib052758d6a7deaa1c62660fd43d8f0e31f42bc09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@happyCoder92 happyCoder92 happyCoder92 left review comments

@cblichmann cblichmann cblichmann requested changes

@fluxchief fluxchief fluxchief requested changes

Assignees
No one assigned
Labels
cla: yes CLA accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexelex @cblichmann @fluxchief @happyCoder92