Introduce SAPI_ASSERT_OK #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a SAPI_ASSERT_OK_AND_ASSIGN which corespondents to SAPI_ASSIGN_OR_RETURN. We also have SAPI_RETURN_IF_ERROR but we don't have a coresponding macro for ASSERT. I think that this completes the API and makes writting tests a little bit simpler.
|
LGTM, pending internal review. GoogleTest will eventually ship matchers as well (with the |
happyCoder92
pushed a commit
that referenced
this pull request
May 4, 2022
PiperOrigin-RevId: 435267982 Change-Id: I8f877da70282df9192be4cfe43d74d1539b9824f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a SAPI_ASSERT_OK_AND_ASSIGN which corespondents to
SAPI_ASSIGN_OR_RETURN.
We also have SAPI_RETURN_IF_ERROR but we don't have a coresponding
macro for ASSERT.
I think that this completes the API and makes writting tests a little
bit simpler.