-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mdl-layout__header--scroll not working in small screen #4180
Comments
Thanks for the issue, @vince8864! Any chance you can share a codepen that illustrates the issue? |
http://codepen.io/anon/pen/WwwmPW |
Yup, I can confirm. Thanks for the bug, @vince8864, I'll look into this! |
Hey @vince8864. I took a look at this today, and I can't find a backwards-compatible way of fixing this. Basically, the reason this happens is because of a bugfix that's intended to prevent scrolling beyond the end of a large drawer: You can try adding the following CSS to your project and testing whether this solves the problem for you, although it may introduce the above bug: .mdl-layout__container.has-scrolling-header .mdl-layout--fixed-header .mdl-layout__content {
overflow-y: visible;
overflow-x: visible;
overflow: visible;
} V2 will have a completely revamped way of doing layout; I'm keeping this bug open until that's implemented, both as a reminder and as information for anyone running into the same bug as you. |
Hi sgomes, your suggested css works wonder for me. Here is my output. Second, after applying your suggested css, the header is now scrollable regardless of browser size. Thanks for everything. The word revamped seem exciting yet intimidating. Hope nothing breaks. 😄 |
Back-porting un-applied upstream fix google/material-design-lite#4180, fixing failure of config.mode == Scrolling on mobile. Fix #122.
In small screen, the header is no longer scrollable even with mdl-layout__header--scroll. Is it possible enable this in small screen as well? At least tell me how i can achieve this. Thanks
Another simple question, If i add below css modification to mdl layout, will there be any implication? So far it looks fine to me. I need this because i use mdl in concrete5 which has a fixed toolbar on top. Kind of like mdl header. Without this css hack, i would have double scrollbar. The overflow can be any value other than auto or scroll. Please advise. Thanks
.mdl-layout {overflow-y:visible !important; overflow-x:visible !important; }
The text was updated successfully, but these errors were encountered: