Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore annotations on type alias #1684

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Conversation

neetopia
Copy link
Contributor

fixes #1679

@neetopia neetopia requested a review from ting-yuan January 18, 2024 09:12
@neetopia neetopia merged commit 024b17a into google:main Jan 18, 2024
2 checks passed
@neetopia neetopia deleted the alias-annotation branch January 18, 2024 18:57
@@ -145,8 +144,7 @@ fun getKSTypeCached(
KSTypeImpl.getCached(
kotlinType,
ksTypeArguments,
annotations + kotlinType.annotations
.filter { it.source == SourceElement.NO_SOURCE }
kotlinType.annotations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the filter might have caused #1696

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind found the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Annotations missing on KSTypeArgument of typealias
3 participants