This repository was archived by the owner on Dec 5, 2022. It is now read-only.
Cleanup #350
Merged
Cleanup #350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -28,4 +28,12 @@ | |||
| // }); | |||
| // } | |||
|
|
|||
| // exports.addEventListener('page-transition-done', function(e) { | |||
There was a problem hiding this comment.
get rid of this and file a bug?
There was a problem hiding this comment.
The bug is #331, but using it is imminent so I left the comment for others.
|
reviewed. Can you add some docs for Is it fair to say that it only fires after a page transition is triggered and is complete, so it's guaranteed not to fire multiple times without a page transition having happened in between, for instance? |
|
Yea, only when the page is fully complete. |
|
PTAL |
|
LGTM ⏰ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @devnook, all