Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused imports and warnings #3356

Closed
wants to merge 2 commits into from
Closed

Remove unused imports and warnings #3356

wants to merge 2 commits into from

Conversation

OleksiiBondar
Copy link
Contributor

  • Remove unused imports.
  • Remove suppress warning annotations where not applicable and/or update suppression types

@OleksiiBondar
Copy link
Contributor Author

@liach Thanks, added similar changes to android as well

@liach
Copy link

liach commented Dec 25, 2018

looks good (imo this has a big chance of merging as it's a bugfix)

@cpovirk
Copy link
Member

cpovirk commented Jan 30, 2019

Not sure what we're doing with serial warnings nowadays, but I'll import the rest of this. Thanks.

@ronshapiro ronshapiro mentioned this pull request Feb 14, 2019
Closed
ronshapiro pushed a commit that referenced this pull request Feb 14, 2019
@OleksiiBondar @ronshapiro
Remove unused imports and warnings.
3d35188 
Fixes #3356

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=231638663
@ronshapiro ronshapiro mentioned this pull request Feb 26, 2019
Merged
ronshapiro pushed a commit that referenced this pull request Feb 26, 2019
@OleksiiBondar @ronshapiro
Remove unused imports and warnings.
f0945a2 
Fixes #3356

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=231638663
ronshapiro pushed a commit that referenced this pull request Feb 26, 2019
@OleksiiBondar @ronshapiro
Remove unused imports and warnings.
735fb5a 
Fixes #3356

RELNOTES=n/a

-------------
Created by MOE: https://github.com/google/moe
MOE_MIGRATED_REVID=231638663
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cpovirk cpovirk

Labels
cla: yes status=triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OleksiiBondar @liach @cpovirk @kluever @googlebot