Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed @Beta for toImmutableList and toImmutableMap #3280

Closed
wants to merge 14 commits into from

Conversation

yuyumao
Copy link

@yuyumao yuyumao commented Oct 1, 2018

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@yuyumao
Copy link
Author

yuyumao commented Oct 1, 2018

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@zshamrock
Copy link

zshamrock commented Oct 1, 2018

@yuyumao just to double check do you also consider to remove @Beta from other immutable collection classes, like

  • ImmutableBiMap,
  • ImmutableListMultimap,
  • ImmutableSet,
  • ImmutableSetMultimap,
  • ImmutableSortedMap,
  • ImmutableSortedSet

Maybe there are others, but these are the ones I've found.

@yuyumao
Copy link
Author

yuyumao commented Oct 2, 2018

@zshamrock I've added all the classes you listed

@danielhultqvist
Copy link

@netdpb Any updates on this PR? Seems that the failing Travis build is probably unrelated. My team are hesitant of using the collectors as it warns about the usage in IDEA

@cpovirk
Copy link
Member

cpovirk commented Apr 29, 2019

#3393

@cpovirk cpovirk closed this Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants