fix: Take the C++ standard version into account when using __has_cpp_attribute
#4722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I ran into this issue and verified this fix on Ubuntu 24.04 using googletest v1.16.0 and clang 19.1.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4605
As elaborated in the issue,
GTEST_INTERNAL_HAVE_CPP_ATTRIBUTE(maybe_unused)failing to consider the C++ standard can cause-Wc++17-attribute-extensionswarning in C++14.This PR applies the patch equivalent to what the issue proposed, but uses
GTEST_INTERNAL_CPLUSPLUS_LANGinstead of__cplusplus.